Skip to content

Commit

Permalink
Remove duplicate reports_count parameter
Browse files Browse the repository at this point in the history
Duplicate parameters now return an error starting with Puppet 3.8.5 and
4.3.2. https://tickets.puppetlabs.com/browse/PUP-5590
  • Loading branch information
badgerben committed Jan 28, 2016
1 parent fbdd6bb commit 80ef518
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions manifests/init.pp
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,6 @@
# (string) Commit, tag, or branch from Puppetboard's Git repo to be used
# Defaults to undef, meaning latest commit will be used ($::puppetboard::params::revision)
#
# [*reports_count*]
# (string) the number of reports to display
# Defaults to 10
#
# [*manage_git*]
# (bool) If true, require the git package. If false do nothing.
# Defaults to false
Expand Down Expand Up @@ -161,7 +157,6 @@
$python_proxy = $::puppetboard::params::python_proxy,
$experimental = $::puppetboard::params::experimental,
$revision = $::puppetboard::params::revision,
$reports_count = $::puppetboard::params::reports_count,
$manage_selinux = $::puppetboard::params::manage_selinux,
$manage_user = true,
$manage_group = true,
Expand Down

3 comments on commit 80ef518

@ryno75
Copy link

@ryno75 ryno75 commented on 80ef518 Feb 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How soon can we get this pushed to the forge? Version 2.7.3 is totally borked on the latest version of Puppet 4.

@sjoeboo
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, 2.7.3 is hosed on the forge.

@apeeters
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #118.

Please sign in to comment.