-
-
Notifications
You must be signed in to change notification settings - Fork 164
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
update documentation to reflect puppetdb_ssl is supposed to be a bool…
…ean and not a string
- Loading branch information
Showing
2 changed files
with
16 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6b95a6a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrong. That parameter should be EITHER a bool or a string.
Check the readme from puppetboard... https://github.com/voxpupuli/puppetboard/blob/master/README.rst#id16
Further... if you look at the app.py file where it uses the PUPPETDB_SSL_VERIFY it is using the pypuppetdb.connect method which has the following in its docstring:
:param ssl_verify: (optional) Verify PuppetDB server certificate.
:type ssl_verify: :obj:
bool
or :obj:string
True, False or filesystem path to CA certificate.Also... this breaks PuppetDB SSL auth. That arg needs to point to the CA cert.