Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add switches for simple domain masquerade #326

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Add switches for simple domain masquerade #326

merged 1 commit into from
Apr 12, 2022

Conversation

jcpunk
Copy link
Contributor

@jcpunk jcpunk commented Mar 8, 2022

Pull Request (PR) description

When setting up simple mail routing, it is handy to have a quick way to setup domain masquerade to convert messages for DKIM or SPF acceptance.

This Pull Request (PR) fixes the following issues

None

@jcpunk
Copy link
Contributor Author

jcpunk commented Mar 8, 2022

Looks like I'll need some help with the tests

manifests/satellite.pp Outdated Show resolved Hide resolved
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are almost there! More hints for CI and a few minor remarks.

manifests/mta.pp Outdated Show resolved Hide resolved
manifests/mta.pp Outdated Show resolved Hide resolved
@jcpunk jcpunk requested a review from smortex March 9, 2022 17:30
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! If you want, you can duplicate the parameters description in the comments above the classes so that it makes the life of the future person who wants to use puppet-string to manage the module documentation easier. In any case, i am fine with this 👍

@jcpunk
Copy link
Contributor Author

jcpunk commented Apr 12, 2022

Any chance for a merge? I've been using it locally with this change for a bit now.

@smortex
Copy link
Member

smortex commented Apr 12, 2022

Nobody seems to be worried about this change so let's merge it! Thanks!

@smortex smortex merged commit 1cdc9ac into voxpupuli:master Apr 12, 2022
@jcpunk jcpunk deleted the masqurade branch April 13, 2022 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants