Remove config when module is ensured to absent #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #477 |
bastelfreak
reviewed
Sep 25, 2018
manifests/extension/config.pp
Outdated
| exec { $cmd: | ||
| onlyif => "${ext_tool_query} -s ${_sapi} -m ${so_name} | /bin/grep 'No module matches ${so_name}'", | ||
| require => ::Php::Config[$title], | ||
| } | ||
| } | ||
|
|
||
| if $php::fpm { |
There was a problem hiding this comment.
I think this is specific to Debian as well?
|
Hi @amateo, thanks for this PR as well! Can you take a look at travis? The jobs are failing on CentOS, probably because of the if block in line 118 (see my inline comment for that). Could you add an acceptance test for this so we know it's working properly now? |
When the module is ensured to absent, it removes its config and not try to create the config file and enable it.
|
Hi @bastelfreak. I think all problems are now solved. |
|
Thanks! |
|
This patch ends up being a bit of a wild goose chase for all the available values of $ensure, since it can also be 'snapshot' or a pinned version. Even with #485 these will be marked as 'absent'. Doesn't it make more sense for line 93 to simply be |
Merged
|
I have just made #493 with this last change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the module is ensured to absent, it removes its config and not try
to create the config file and enable it.