add tests for php5.6 #418

bastelfreak · 2018-02-17T10:19:19Z

No description provided.

software-properties-common is needed to add ppas on ubuntu. the puppetlabs-apt module can manage the package. it is save to enable this, because the module uses ensure_package: https://github.com/puppetlabs/puppetlabs-apt/blob/df40baebedf5c0c15e08f3ec78adfd760b1371ca/manifests/ppa.pp#L30 Without this, managing ppa repos at least on ubuntu 16.04 is impossible. I noticed this bug while testing with aceptance tests in voxpupuli#418

bastelfreak · 2018-02-17T14:11:09Z

The new spec file alone is working. Our module doesn't support the upgrade/downgrade of the php version, and beaker-rspec executes all tests in the same container. This seems to work in other modules like jenkins??

ekohl · 2018-02-23T11:24:57Z

If we do go this way, I'd prefer the following in .sync.yml

---
.travis.yml:
  docker_sets:
    - set: docker/ubuntu-16.04
      options:
        script: 'bundle exec rspec spec/acceptance/php56_spec.rb'
    - set: docker/ubuntu-14.04
      options:
        script: 'bundle exec rspec spec/acceptance/php56_spec.rb'
    - set: docker/centos-7
      options:
        script: 'bundle exec rspec spec/acceptance/php56_spec.rb'
    - set: docker/debian-8
      options:
        script: 'bundle exec rspec spec/acceptance/php56_spec.rb'
    - set: docker/ubuntu-16.04
      options:
        script: 'bundle exec rspec spec/acceptance/php_spec.rb'
    - set: docker/ubuntu-14.04
      options:
        script: 'bundle exec rspec spec/acceptance/php_spec.rb'
    - set: docker/centos-7
      options:
        script: 'bundle exec rspec spec/acceptance/php_spec.rb'
    - set: docker/debian-8
      options:
        script: 'bundle exec rspec spec/acceptance/php_spec.rb'

ekohl · 2018-02-23T11:26:47Z

spec/acceptance/php56_spec.rb

+    end
+
+    case default[:platform]
+    when %r{16.04}


Isn't this the same as 14.04? Would it be better to test for the Debian OS family or at least Ubuntu?

ekohl · 2018-02-23T11:27:30Z

spec/acceptance/php_spec.rb

-    describe package('php-fpm') do
-      it { is_expected.to be_installed }
+
+    case default[:platform]


I'd prefer to set the expected package name in a case statement (with a let block?) and then have the same describe block with a variable

implemented it, just without the let block (didn't work)

this will go upstream into modulesync_config

this will execute each of them in their own container

foxxx0

looks good to me

ekohl

I'm thinking about environment variables rather than explicit filenames. You can do describe "case", if/unless: ... do and set the variables via Travis.

ekohl · 2018-03-06T13:10:31Z

spec/acceptance/php56_spec.rb

+
+describe 'with specific php version' do
+  case default[:platform]
+  when %r{16.04}


Wouldn't it be better to just check for Ubuntu here?

yeah would work as well

ekohl · 2018-03-06T13:10:43Z

spec/acceptance/php56_spec.rb

+    packagename = 'php5.6-fpm'
+  when %r{14.04}
+    packagename = 'php5.6-fpm'
+  when %r{7}


Is this Debian 7 or CentOS 7?

ekohl · 2018-03-06T13:10:52Z

spec/acceptance/php56_spec.rb

+    packagename = 'php5.6-fpm'
+  when %r{7}
+    packagename = 'php-fpm'
+  when %r{8}


I'm guessing Debian?

ekohl · 2018-03-06T13:14:25Z

spec/acceptance/php56_spec.rb

@@ -0,0 +1,45 @@
+require 'spec_helper_acceptance'
+
+describe 'with specific php version' do


How about a check for php --version?

ekohl · 2018-03-06T14:51:16Z

spec/acceptance/php_spec.rb

+      package = 'php5-fpm'
+    when %{centos}
+      package = 'php-fpm'
+    when %{'debian'}


Are the quotes needed here? should it be a regex too?

ekohl · 2018-03-06T14:51:44Z

spec/acceptance/php56_spec.rb

+      it { is_expected.to be_enabled }
+    end
+    describe command('php --version') do
+      its(:stdout) { is_expected.to match %r{5.6} }


Should the dot in 5.6 be escaped since it's a regex char?

bastelfreak · 2018-03-06T16:40:50Z

finally green

software-properties-common is needed to add ppas on ubuntu. the puppetlabs-apt module can manage the package. it is save to enable this, because the module uses ensure_package: https://github.com/puppetlabs/puppetlabs-apt/blob/df40baebedf5c0c15e08f3ec78adfd760b1371ca/manifests/ppa.pp#L30 Without this, managing ppa repos at least on ubuntu 16.04 is impossible. I noticed this bug while testing with aceptance tests in voxpupuli#418

bastelfreak mentioned this pull request Feb 17, 2018

manage software-properties-common on ubuntu #419

Merged

bastelfreak force-pushed the acceptancephp56 branch 2 times, most recently from c2f1975 to d2ce25b Compare February 17, 2018 13:16

bastelfreak force-pushed the acceptancephp56 branch from 2f3c965 to f2ef150 Compare February 19, 2018 22:18

bastelfreak changed the title ~~[WIP]add tests for php5.6~~ add tests for php5.6 Feb 22, 2018

bastelfreak force-pushed the acceptancephp56 branch 2 times, most recently from 4fdf8c8 to 4452c22 Compare February 22, 2018 23:46

ekohl requested changes Feb 23, 2018

View reviewed changes

bastelfreak added 5 commits March 3, 2018 10:42

add tests for php5.6

6ca17a4

fix the ubuntu16.04 nodeset

d3045fb

this will go upstream into modulesync_config

run acceptance tests on each spec file

c0cb2d0

this will execute each of them in their own container

add acceptance tests to modulesync config

3412e96

use modulesync to generate acceptance tests

eb6fcdb

bastelfreak force-pushed the acceptancephp56 branch 3 times, most recently from ba844bc to 9650477 Compare March 6, 2018 12:49

foxxx0 approved these changes Mar 6, 2018

View reviewed changes

ekohl reviewed Mar 6, 2018

View reviewed changes

bastelfreak force-pushed the acceptancephp56 branch 2 times, most recently from 8e1e38b to dd275af Compare March 6, 2018 14:47

ekohl requested changes Mar 6, 2018

View reviewed changes

bastelfreak force-pushed the acceptancephp56 branch 6 times, most recently from 592c464 to fcccf06 Compare March 6, 2018 15:48

bastelfreak force-pushed the acceptancephp56 branch 3 times, most recently from b0d1cb2 to 761eec2 Compare March 6, 2018 16:21

bastelfreak added 2 commits March 6, 2018 17:26

restructure php56 acceptance tests

4544b3b

cleanup php7 acceptance test

2b970d7

bastelfreak force-pushed the acceptancephp56 branch from 761eec2 to 2b970d7 Compare March 6, 2018 16:26

ekohl approved these changes Mar 6, 2018

View reviewed changes

bastelfreak merged commit b98a6a5 into voxpupuli:master Mar 6, 2018

bastelfreak deleted the acceptancephp56 branch March 6, 2018 16:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add tests for php5.6 #418

add tests for php5.6 #418

bastelfreak commented Feb 17, 2018

bastelfreak commented Feb 17, 2018 •

edited

Loading

ekohl commented Feb 23, 2018

ekohl Feb 23, 2018

ekohl Feb 23, 2018

bastelfreak Mar 6, 2018

foxxx0 left a comment

ekohl left a comment

ekohl Mar 6, 2018

bastelfreak Mar 6, 2018

ekohl Mar 6, 2018

ekohl Mar 6, 2018

ekohl Mar 6, 2018

ekohl Mar 6, 2018

ekohl Mar 6, 2018

bastelfreak commented Mar 6, 2018

		@@ -0,0 +1,45 @@
		require 'spec_helper_acceptance'

		describe 'with specific php version' do

add tests for php5.6 #418

add tests for php5.6 #418

Conversation

bastelfreak commented Feb 17, 2018

bastelfreak commented Feb 17, 2018 • edited Loading

ekohl commented Feb 23, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

foxxx0 left a comment

Choose a reason for hiding this comment

ekohl left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bastelfreak commented Mar 6, 2018

bastelfreak commented Feb 17, 2018 •

edited

Loading