replace legacy facts with new $facts hash #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhollinger
approved these changes
Jun 29, 2017
dbeckham
added a commit
to dbeckham/puppet-php
that referenced
this pull request
Aug 10, 2017
This fixes a bug introduced in voxpupuli#357 where Debian repositories were being selected on Ubuntu.
alexjfisher
reviewed
Aug 11, 2017
| @@ -98,7 +98,7 @@ | |||
|
|
|||
| # Create an override to use a reload signal as trusty and utopic's | |||
| # upstart version supports this | |||
| if $::operatingsystem == 'Ubuntu' and ($::operatingsystemmajrelease == '14.04' or $::operatingsystemmajrelease == '14.10') { | |||
| if $facts['os']['name'] == 'Ubuntu' and ($facts['os']['release']['major'] == '14') { | |||
There was a problem hiding this comment.
Turns out 'major' is actually '14.04' not just '14'. https://github.com/camptocamp/facterdb/blob/54422fbe9e32cfacddae5403237ee2758a7f26af/facts/3.7/ubuntu-14.04-x86_64.facts#L339
motivator
pushed a commit
to bigcommerce/puppet-php
that referenced
this pull request
Oct 5, 2020
This fixes a bug introduced in voxpupuli#357 where Debian repositories were being selected on Ubuntu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.