Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional param to prefix the extension ini filename #333

Merged
merged 1 commit into from
Aug 2, 2017

Conversation

spacepants
Copy link
Contributor

Hey there,

So when loading extensions, sometimes it's desirable to specify the extension load order — for example loading opcache before other modules. This adds support for prefixing the extension ini filename to accomplish this.

Copy link

@poikilotherm poikilotherm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch seems very reasonable to me.

Seems to be the resolution to #272.

Please merge this ASAP - this resolves the issue of "duplicate" ini files on RHEL as they have such prefixes. (This leads to warnings about reloading of extensions, which is absolutely not necessary and prone to cause even worse errors.)

@jk2l
Copy link
Contributor

jk2l commented May 17, 2017

how will this fix the duplicate issue? let say if the default installed 10-module.ini and you want to raise the load order to 20-module.ini, the issue same with other similar pull request it will not delete the 10-module.ini caused duplicate ini file.

@poikilotherm
Copy link

@jk2l, you are right. At least, you don't get duplicated files with default names like "10-module.ini" and "module.ini". Instead, the default file will get edited and options are added.

Maybe @spacepants could extend his code to use a tidy resource to cleanup any unmanaged files for the extensions now under puppet control?

@hunner hunner merged commit bbee264 into voxpupuli:master Aug 2, 2017
hunner added a commit that referenced this pull request Aug 2, 2017
Add optional param to prefix the extension ini filename
@hunner hunner added the enhancement New feature or request label Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants