Merge pull request #374 from dbeckham/fix_os_name_fact_issue

Fix OS facts usage when selecting repo class for Ubuntu systems

manifests/repo.pp

@@ -7,7 +7,7 @@
   case $facts['os']['family'] {
     'Debian': {
       # no contain here because apt does that already
-      case $facts['os']['family'] {
+      case $facts['os']['name'] {
         'Debian': {
           include ::php::repo::debian
         }

spec/classes/php_repo_spec.rb

@@ -0,0 +1,27 @@
+require 'spec_helper'
+
+describe 'php::repo', type: :class do
+  on_supported_os.each do |os, facts|
+    context "on #{os}" do
+      let :facts do
+        facts
+      end
+
+      describe 'when configuring a package repo' do
+        case facts[:osfamily]
+        when 'Debian'
+          case facts[:operatingsystem]
+          when 'Debian'
+            it { is_expected.to contain_class('php::repo::debian') }
+          when 'Ubuntu'
+            it { is_expected.to contain_class('php::repo::ubuntu') }
+          end
+        when 'Suse'
+          it { is_expected.to contain_class('php::repo::suse') }
+        when 'RedHat'
+          it { is_expected.to contain_class('php::repo::redhat') }
+        end
+      end
+    end
+  end
+end