Fix $openldap::server::database data type #329
Conversation
smortex
changed the title
| @@ -7,7 +7,7 @@ | |||
| Optional[String[1]] $backend = undef, | |||
| Optional[String[1]] $rootdn = undef, | |||
| Optional[String[1]] $rootpw = undef, | |||
| Optional[String[1]] $initdb = undef, | |||
| Optional[Boolean] $initdb = undef, | |||
There was a problem hiding this comment.
I find Optional strange for Booleans, because isn't undef equivalent to false? Seems like the default is true in the type. Maybe remove Optional and default it to true?
There was a problem hiding this comment.
Yes, this is indeed over-complicated and I was trying to decipher this.
Defaulting to true should be the right thing to do.
There was a problem hiding this comment.
I had to reverse this because the default value actually depend on the backend.
smortex
force-pushed
the
initdb-data-type
branch
from
23651bd to
0e35673
Compare
It is expected to be a boolean value. Was typed as string by mistake in c2ea6cb. While here, fix the parameter description.
smortex
force-pushed
the
initdb-data-type
branch
from
0e35673 to
adca4cd
Compare
|
Okay, to quote a comment once read on a mailing list, "Don't trust the comments!" :-) The parameter defaults to true… unless we are in the cases where it default to false 🙃 At least, we have a CI that helped reading the right information in the right place! Reverted and updated the doc to match the code. |
Pull Request (PR) description
It is expected to be a boolean value. Was typed as string by mistake in
c2ea6cb.
This Pull Request (PR) fixes the following issues
Fixes #328