-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Acceptance tests for CentOS 7 , remove RHEL6 #309
Conversation
Ugh, the failures are a long standing issue I've run into where systemd processes running inside a Docker container will throw errors on startup if they run as someone other than root due to some weirdness with cgroups inside container and what systemd expects to see. With several of my modules I've had to hack things to force the daemon run as root in something that runs in a |
This is what I had to do for one of my modules: It's really ugly but it works to avoid this issue. |
hey @treydock, |
@bastelfreak Thanks for the pointers, I made the necessary adjustments but still seeing failures. Not quite sure why things still failed, I see that beaker setfile was correct:
The generated Dockerfile also used this specific version. |
meh. We sometimes see strange systemd failures on docker containers, I've no clue what's the correct workaround here :( |
@bastelfreak I think I fixed the issues. The only way I could get this to work was force |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the workaround is clearly indicated, I am fine with this!
Do you mind arranging the commits (there are a few tries & reverts)?
Maybe we can also add CentOS 8 and RedHat 8 in metadata.json (if it works, otherwise it will be in another PR 😋)?
9445368
to
8c57ed9
Compare
@smortex I squashed the commits down. Enabling CentOS/RHEL 8 isn't possible without significant changes. RHEL8 dropped openldap-servers packages so all they provide is openldap client packages. I tried to get EPEL to approve packaging just the openldap-servers packages but was denied since upstream RHEL provides conflicting client packages. To enable CentOS 8 / RHEL 8 support will require a new PR that is much more involved that pulls the openldap packages from non-OS and non-EPEL repos. There are a few sources that were mentioned to me in my EPEL request so can try those out. |
Pull Request (PR) description
Add CentOS 7 to metadata.json hoping that will trigger acceptance tests.
Remove RHEL6 from metadata.json, that OS version is EOL