Merge pull request #332 from voxpupuli/simplify-iterate_access

Simplify some code duplication
voxpupuli · Oct 7, 2021 · 74e6602 · 74e6602
2 parents e3de7ff + 995aea4
commit 74e6602
Showing 1 changed file with 10 additions and 19 deletions.
diff --git a/manifests/server/iterate_access.pp b/manifests/server/iterate_access.pp
@@ -14,26 +14,17 @@
     fail('$access variable must be an array')
   }
 
-  if $position == 0 { # the first entry
+  $previous_position = $position - 1
 
-    openldap::server::access { "${position} on ${suffix}" :
-      what   => $what,
-      access => $access,
-    }
-  } elsif $position == $count { #the last entry
-
-    $previous_position = $position - 1
-    openldap::server::access { "${position} on ${suffix}" :
-      what    => $what,
-      access  => $access,
-      require => Openldap::Server::Access["${previous_position} on ${suffix}"],
-    }
+  if $previous_position < 0 {
+    $require = []
   } else {
-    $previous_position = $position - 1
-    openldap::server::access { "${position} on ${suffix}" :
-      what    => $what,
-      access  => $access,
-      require => Openldap::Server::Access["${previous_position} on ${suffix}"],
-    }
+    $require = Openldap::Server::Access["${previous_position} on ${suffix}"]
+  }
+
+  openldap::server::access { "${position} on ${suffix}" :
+    what    => $what,
+    access  => $access,
+    require => $require,
   }
 }