Bond improvements

[vholer]

Following simple patches introduce 3 options for defined resource network::bond{ }.

• hotplug which is propagated to bond interface (user usually wants to set to non-default false)
• options which is merged with bonding options (user can use it to set additional options on bond interface, e.g. disable network manager or set bridge interface for more advanced configuration)
• slave_options which is merged with MASTER/SLAVE options on bond slave interfaces

For example on Red Hat I can now easily disable Network Manager on all interfaces and set bridge over bond and also disable hotplug, which doesn't have sense for these interfaces:

network::bond { 'bond0':
  ensure  => present,
  onboot  => 'true',
  hotplug => 'false',
  slaves  => ['ens1f0','ens1f1'],
  mode    => 'active-backup',
  options => {
    'BRIDGE'        => 'br0',
    'NM_CONTROLLED' => 'no',
  },
  slave_options => {
    'NM_CONTROLLED' => 'no',
  },
}

[adrienthebo]

Looks sane to me. @jhoblitt @ffrank @igalic ?

[jhoblitt]

@adrienthebo At first glance, this looks good to me too. Someone should still test it before merging... we really need acceptance tests in-tree.

[igalic]

@nibalizer ping. do you have acceptance tests infra somewhere?

[nibalizer]

@igalic I do. (We do.) But this module doesn't have acceptance tests.

[igalic]

oy _