Set mode "raw" to existing non-VLAN interfaces on Debian

[vholer]

When reading interfaces configuration on Debian, "raw" mode isn't set for non-VLAN interfaces. Puppet then fixes the mode from undefined to raw again and again and again with every run. E.g.:

Notice: /Stage[main]/Network_config[ib0]/mode: mode changed '' to 'raw'

Following simple patch fixes this behaviour on Debian, including tests.

[jhoblitt]

This looks good. 👍

[ffrank]

Can you elaborate on exactly what is going on?

I can find no mention of the mode of an iface in interfaces(5) on sid or wheezy, nor any mention of what raw signifies.

[jhoblitt]

@ffrank :raw means the interface being configured is not a vlan-raw-device. It could equally have been :plain, :normal, :standard, or :generic but I went with :raw.

[ffrank]

Thanks @jhoblitt.

👍 from me as well then.

[jhoblitt]

@ffrank It turns out that even for something as "standardized" as networking, it's difficult to find terms that convey the same meaning across multiple platforms.

[vholer]

If you are OK with that, is it possible to merge previous commits so that the resource stops changing mode to raw again and again and again please? Thank you.

[adrienthebo]

Thanks for the contribution!

[vholer]

Thank you too, looks good to me. Thanks!