Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file expansion problem with PE. #40

Merged
merged 1 commit into from
May 29, 2013

Conversation

nanliu
Copy link
Contributor

@nanliu nanliu commented May 29, 2013

No description provided.

adrienthebo added a commit that referenced this pull request May 29, 2013
Fix file expansion problem with PE.
@adrienthebo adrienthebo merged commit 206c2d7 into voxpupuli:master May 29, 2013
@adrienthebo
Copy link
Member

@nanliu thanks much for this submission!

Out of curiosity, how did you discover this? I'm wondering if #38 and #39 are related to this same issue.

@Aethylred
Copy link

Yes, this has resolved #39, but new behavior observed. Will create a new issue.

edit New behavior is just a result of first run and not repeatable, no issue necessary.

@nanliu
Copy link
Contributor Author

nanliu commented May 29, 2013

@adrienthebo, when I updated my module, there was only a few lines of code change triggering #39, so it was pretty easy to narrow down.

@adrienthebo
Copy link
Member

@Aethylred whew, glad to know there wasn't a new issue. :)

Thanks again @Aethylred for reporting this and @nanliu for fixing it!

@nanliu
Copy link
Contributor Author

nanliu commented May 29, 2013

@Aethylred, I made a temporary fix to avoid pluginsync, wonder if that's the issue for first run: nanliu@59e8773

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants