Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated version for module dependency camptocamp/kmod #122

Merged
merged 2 commits into from
Oct 21, 2015

Conversation

dustyhorizon
Copy link

No description provided.

@igalic
Copy link
Contributor

igalic commented Oct 19, 2015

@dustyhorizon what does that bump mean for our own version?

@ffrank
Copy link
Contributor

ffrank commented Oct 19, 2015

Also, sure - let's not tie users to ancient versions of dependencies, but this is overly restrictive/trigger happy. Basically we just care about >=0.0.1 right?

@dustyhorizon
Copy link
Author

Ah yes, let me edit my code and do a re-pull, sorry I am new to this.

As for the reason for this pull is that librarian-puppet complains about depenency issues if I used the latest version of the module (as I require the module in my other profile) and the old version of the kmod module causes an error whilst loading a kernel module.

@igalic
Copy link
Contributor

igalic commented Oct 20, 2015

@dustyhorizon if you need a hand with git, do shout. we're also available in #puppet-community on freenode.

@ffrank
Copy link
Contributor

ffrank commented Oct 21, 2015

All right! Thanks. These commits could be squashed, but I'd be fine with keeping them in this case, because they illustrate the intent well.

I'm also in favor of just merging this. This change should have no impact for users who pull it as an update.

igalic added a commit that referenced this pull request Oct 21, 2015
updated version for module dependency camptocamp/kmod
@igalic igalic merged commit c8ade3f into voxpupuli:master Oct 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants