Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

While configuration checked interface incorrectly marked as changed #13

Closed
ewtewt opened this issue Nov 28, 2012 · 7 comments
Closed

While configuration checked interface incorrectly marked as changed #13

ewtewt opened this issue Nov 28, 2012 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@ewtewt
Copy link

ewtewt commented Nov 28, 2012

OS: RedHat
CHANGES TO CONFIGURATION: only by puppet

LOG:
...
/Network_config[bond0.126:111]/family: family changed '' to 'inet'
/Network_config[bond0.126:111]/onboot: onboot changed 'true' to 'true'
Info: FileBucket adding {md5}2ace49d5d0d14c1220b6d8a6b0cb0e72
Info: /Network_config[bond0.126:111]: Scheduling refresh of Service[network]
Info: /Network_config[bond0.126:111]: Scheduling refresh of Service[network]
...

Network refresh makes server unavailible for a couple seconds every puppet lunch without any changes to configuration.

@adrienthebo
Copy link
Member

@ewtewt would you be willing to provide the puppet resource you're using in this case, and the resulting file that's generated in /etc/sysconfig/network/ifcfg-bond0.126:111 ?

@ghost ghost assigned adrienthebo Nov 28, 2012
@ewtewt
Copy link
Author

ewtewt commented Nov 28, 2012

resource:

network_config { "bond0.126:111":
ensure => "present",
family => "inet",
method => "static",
ipaddress => "10.126.0.111",
netmask => "255.255.0.0",
onboot => "true",
}

/etc/sysconfig/network-scripts/ifcfg-bond0.126:111 :
ONBOOT=yes
BOOTPROTO=static
IPADDR=10.126.0.111
DEVICE=bond0.126:111
NETMASK=255.255.0.0

@adrienthebo
Copy link
Member

@ewtewt I have patches for the problems that you've seen at https://github.com/adrienthebo/puppet-network/tree/redhat-quiesce, would you be able to test this topic branch?

adrienthebo added a commit that referenced this issue Dec 6, 2012
Puppet presents boolean values `true` and `false` to underlying classes
as symbols instead of actual booleans, so boolean types in the
providers were falsely being marked as out of sync. This normalizes
values for that.
adrienthebo added a commit that referenced this issue Dec 6, 2012
Per #13 and #16 the inet property doesn't make a lot of sense right now,
and since it's not being set in the redhat provider that property is
always out of sync. This is the brute force method of always setting
this property till #16 gets implemented and removes this value entirely.
adrienthebo added a commit that referenced this issue Dec 7, 2012
Puppet presents boolean values `true` and `false` to underlying classes
as symbols instead of actual booleans, so boolean types in the
providers were falsely being marked as out of sync. This normalizes
values for that.
adrienthebo added a commit that referenced this issue Dec 7, 2012
Per #13 and #16 the inet property doesn't make a lot of sense right now,
and since it's not being set in the redhat provider that property is
always out of sync. This is the brute force method of always setting
this property till #16 gets implemented and removes this value entirely.
@ewtewt
Copy link
Author

ewtewt commented Dec 7, 2012

I cannot find link to download tarball for branch redhat-quiesce. Only for master.

@adrienthebo
Copy link
Member

@ewtewt I have a prerelease of 0.2.0 at http://media.somethingsinistral.net/puppet/adrien-network-0.2.0-pre1.tar.gz , could you try that?

@ewtewt
Copy link
Author

ewtewt commented Dec 7, 2012 via email

@adrienthebo
Copy link
Member

@ewtewt thanks for reporting this and helping to test it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants