network_config::redhat: allow "_" in network interface names #150
Triggered via pull request
September 19, 2024 09:42
olifre
Status
Success
Total duration
1m 46s
Artifacts
–
ci.yml
on: pull_request
Puppet
/
Static validations
34s
Matrix: Puppet / unit
Puppet
/
Test suite
4s
Annotations
10 warnings
|
Puppet / Static validations:
metadata.json#L1
Skipping EOL operating system RedHat 7
|
|
Puppet / Static validations:
metadata.json#L1
Skipping EOL operating system CentOS 7
|
|
Puppet / Static validations:
metadata.json#L1
Skipping EOL operating system CentOS 8
|
|
Puppet / Static validations:
metadata.json#L1
Skipping EOL operating system Debian 10
|
|
Puppet / 8 (Ruby 3.2):
spec/unit/type/network_config_spec.rb#L68
Puppet::Type::Network_config when validating the attribute options is a descendant of the KeyValue property
Failure/Error: expect(Puppet::Type.type(:network_config).propertybyname(:options).ancestors).to include(Puppet::Property::Ensure)
expected [Puppet::Type::Network_config::Options, Puppet::Property, Puppet::Parameter, Puppet::Util::Logging, P...acts, FastGettext::Translation, JSON::Ext::Generator::GeneratorMethods::Object, Kernel, BasicObject] to include Puppet::Property::Ensure
Diff:
@@ -1,12 +1,23 @@
-[Puppet::Property::Ensure]
+[Puppet::Type::Network_config::Options,
+ Puppet::Property,
+ Puppet::Parameter,
+ Puppet::Util::Logging,
+ Puppet::Util::Errors,
+ Puppet::Util,
+ Object,
+ RspecPuppetFacts,
+ FastGettext::Translation,
+ JSON::Ext::Generator::GeneratorMethods::Object,
+ Kernel,
+ BasicObject]
|
|
Puppet / 8 (Ruby 3.2):
spec/unit/type/network_config_spec.rb#L85
Puppet::Type::Network_config when validating the attribute value ipaddress using the inet family fails when passed an IPv6 address
Failure/Error: expect { Puppet::Type.type(:network_config).new(name: 'yay', family: :inet, ipaddress: address6) }.to raise_error(%r{not a valid ipv4 address})
expected Exception with message matching /not a valid ipv4 address/ but nothing was raised
|
|
Puppet / 8 (Ruby 3.2):
spec/unit/type/network_config_spec.rb#L96
Puppet::Type::Network_config when validating the attribute value ipaddress using the inet6 family fails when passed an IPv4 address
Failure/Error: expect { Puppet::Type.type(:network_config).new(name: 'yay', family: :inet6, ipaddress: address4) }.to raise_error(%r{not a valid ipv6 address})
expected Exception with message matching /not a valid ipv6 address/ but nothing was raised
|
|
Puppet / 7 (Ruby 2.7):
spec/unit/type/network_config_spec.rb#L68
Puppet::Type::Network_config when validating the attribute options is a descendant of the KeyValue property
Failure/Error: expect(Puppet::Type.type(:network_config).propertybyname(:options).ancestors).to include(Puppet::Property::Ensure)
expected [Puppet::Type::Network_config::Options, Puppet::Property, Puppet::Parameter, Puppet::Util::Logging, P...ator::GeneratorMethods::Object, JSON::Ext::Generator::GeneratorMethods::Object, Kernel, BasicObject] to include Puppet::Property::Ensure
Diff:
@@ -1,13 +1,25 @@
-[Puppet::Property::Ensure]
+[Puppet::Type::Network_config::Options,
+ Puppet::Property,
+ Puppet::Parameter,
+ Puppet::Util::Logging,
+ Puppet::Util::Errors,
+ Puppet::Util,
+ Object,
+ RspecPuppetFacts,
+ FastGettext::Translation,
+ PSON::Pure::Generator::GeneratorMethods::Object,
+ JSON::Ext::Generator::GeneratorMethods::Object,
+ Kernel,
+ BasicObject]
|
|
Puppet / 7 (Ruby 2.7):
spec/unit/type/network_config_spec.rb#L85
Puppet::Type::Network_config when validating the attribute value ipaddress using the inet family fails when passed an IPv6 address
Failure/Error: expect { Puppet::Type.type(:network_config).new(name: 'yay', family: :inet, ipaddress: address6) }.to raise_error(%r{not a valid ipv4 address})
expected Exception with message matching /not a valid ipv4 address/ but nothing was raised
|
|
Puppet / 7 (Ruby 2.7):
spec/unit/type/network_config_spec.rb#L96
Puppet::Type::Network_config when validating the attribute value ipaddress using the inet6 family fails when passed an IPv4 address
Failure/Error: expect { Puppet::Type.type(:network_config).new(name: 'yay', family: :inet6, ipaddress: address4) }.to raise_error(%r{not a valid ipv6 address})
expected Exception with message matching /not a valid ipv6 address/ but nothing was raised
|