Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replset with gha and modulesync #752

Conversation

h-haaks
Copy link
Contributor

@h-haaks h-haaks commented Apr 22, 2024

Just testing if my updates to puppet_metadata and gha-puppet is working
Branch is based on StatensPensjonskasse:fix-replset-acceptance-testing #743

.sync.yml Outdated
beaker_facter: 'mongodb_repo_version:MongoDB:4.4,5.0,6.0,7.0'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before we merge this, please fix the broken newline.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to fix it in #743 and will close this PR without merge when I'm done with all the gha changes.

uses: StatensPensjonskasse/gha-puppet/.github/workflows/beaker.yml@add-metadata2gha-option-beaker-hosts
with:
pidfile_workaround: 'false'
beaker_hosts: 'host1:shard.ma;host2:slave,router.a'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you raise another PR where beaker_hosts isn't set so we can ensure the change in gha-puppet doens't break existing setups?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All green here now. I'll just do another force push here and remove beaker_hosts to test that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, thanks for having me test that. Ends up with env var BEAKER_SETFILE empty .....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working testrun without beaker_hosts https://github.com/voxpupuli/puppet-mongodb/actions/runs/8834718677

I'm going to add beaker_hosts again to verify that with puppet_metadata 3.7.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@h-haaks h-haaks force-pushed the replset-with-gha-and-modulesync branch from 41c3652 to 54c8f80 Compare April 25, 2024 13:03
@h-haaks h-haaks force-pushed the replset-with-gha-and-modulesync branch from 54c8f80 to f3e59ef Compare April 25, 2024 14:47
@h-haaks
Copy link
Contributor Author

h-haaks commented Apr 25, 2024

Closing this now that #743 is updated and ready to be merged

@h-haaks h-haaks closed this Apr 25, 2024
@h-haaks h-haaks deleted the replset-with-gha-and-modulesync branch April 25, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants