Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mongodb 6.0 and 7.0 to acceptance testing #728

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Add mongodb 6.0 and 7.0 to acceptance testing #728

merged 1 commit into from
Apr 9, 2024
+8 −4

Conversation

h-haaks
Copy link
Contributor

@h-haaks h-haaks commented Apr 3, 2024

No description provided.

@h-haaks h-haaks force-pushed the add-mongodb-6.0-and-7.0-to-acceptance-testing branch from 769951f to 61c1e73 Compare April 3, 2024 11:20
@stevenpost
Copy link
Contributor

The module doesn't yet support MongoDB 7, we need a few more changes for that. Perhaps limit this PR to 6 and add 7 with the PR to actually support it.

@h-haaks
Copy link
Contributor Author

h-haaks commented Apr 3, 2024

The module doesn't yet support MongoDB 7, we need a few more changes for that. Perhaps limit this PR to 6 and add 7 with the PR to actually support it.

Seems to only fail on RedHat.

Service start error mongod.service: main process exited, code=exited, status=2/INVALIDARGUMENT

@h-haaks
Copy link
Contributor Author

h-haaks commented Apr 3, 2024

Seems like storage.journal.enabledis removed in 7.0 config

@h-haaks h-haaks mentioned this pull request Apr 4, 2024
Merged
@h-haaks h-haaks force-pushed the add-mongodb-6.0-and-7.0-to-acceptance-testing branch from 61c1e73 to d126569 Compare April 6, 2024 00:34
@h-haaks
Copy link
Contributor Author

h-haaks commented Apr 6, 2024

The module doesn't yet support MongoDB 7

All tests pass. Anything else you had in mind @stevenpost

stevenpost
stevenpost approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@stevenpost stevenpost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@svbroeker
Copy link

i'm asking for my projects. Do you have a timeframe where you have in mind to release the support of mongodb 6 and 7?

@h-haaks
Copy link
Contributor Author

h-haaks commented Apr 9, 2024

i'm asking for my projects. Do you have a timeframe where you have in mind to release the support of mongodb 6 and 7?

@stevenpost any input? I guess this mainly depends on if we feel confident about the switch to mongosh in the providers?

I'll merge this to get the gha tests running at least.

@h-haaks h-haaks merged commit feaddb1 into voxpupuli:master Apr 9, 2024
44 checks passed
@h-haaks h-haaks deleted the add-mongodb-6.0-and-7.0-to-acceptance-testing branch April 9, 2024 12:07
@stevenpost
Copy link
Contributor

i'm asking for my projects. Do you have a timeframe where you have in mind to release the support of mongodb 6 and 7?

@stevenpost any input? I guess this mainly depends on if we feel confident about the switch to mongosh in the providers?

I'll merge this to get the gha tests running at least.

I'm still testing the no auth scenario, currently working on a proper config. Let's say next week somewhere?

@stevenpost stevenpost mentioned this pull request Apr 29, 2024
Merged
@h-haaks h-haaks added the enhancement New feature or request label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenpost stevenpost stevenpost approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@h-haaks @stevenpost @svbroeker