Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TLS options #645

Merged
merged 4 commits into from
Oct 7, 2022
Merged

Add TLS options #645

merged 4 commits into from
Oct 7, 2022

Conversation

poloz-lab
Copy link
Contributor

@poloz-lab poloz-lab commented Jul 8, 2022

Pull Request (PR) description

Add support of TLS options because SSL options are deprecated since MongoDB 4.2.

You have to switch explicitly from SSL parameters to TLS parameters in the server class.

This Pull Request (PR) fixes the following issues

Fixes #567

@poloz-lab poloz-lab changed the title TLS option TLS options Jul 8, 2022
@poloz-lab poloz-lab force-pushed the tls_option branch 2 times, most recently from 70b5db8 to 96e5c6e Compare July 11, 2022 07:21
@poloz-lab poloz-lab marked this pull request as draft July 11, 2022 07:21
@poloz-lab poloz-lab marked this pull request as ready for review July 11, 2022 07:29
@ghost
Copy link

ghost commented Aug 4, 2022

Any change this can be merged ? Already using this without any problems.
Thank you

@ghost ghost mentioned this pull request Aug 11, 2022
Copy link
Member

@root-expert root-expert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I left some minor comments to be addressed before merging. 😄

spec/classes/server_spec.rb Outdated Show resolved Hide resolved
manifests/server.pp Outdated Show resolved Hide resolved
manifests/server.pp Outdated Show resolved Hide resolved
@root-expert root-expert added the enhancement New feature or request label Sep 18, 2022
@root-expert root-expert changed the title TLS options Add TLS options Sep 18, 2022
@poloz-lab poloz-lab marked this pull request as draft October 4, 2022 11:15
@poloz-lab poloz-lab force-pushed the tls_option branch 7 times, most recently from d1138b1 to 00d0424 Compare October 4, 2022 12:48
@poloz-lab poloz-lab marked this pull request as ready for review October 4, 2022 13:20
Copy link
Member

@root-expert root-expert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@poloz-lab
Copy link
Contributor Author

PR is ready !

@root-expert root-expert merged commit 0121c36 into voxpupuli:master Oct 7, 2022
@poloz-lab poloz-lab deleted the tls_option branch October 7, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSL options deprecated in mongo 4.2.X
2 participants