-
-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TLS options #645
Add TLS options #645
Conversation
70b5db8
to
96e5c6e
Compare
Any change this can be merged ? Already using this without any problems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I left some minor comments to be addressed before merging. 😄
d1138b1
to
00d0424
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😄
…ig file Starting in version 4.2, MongoDB provides net.tls settings. See https://www.mongodb.com/docs/v5.0/tutorial/configure-ssl/#procedures--using-net.tls-settings And tls args for the client : https://www.mongodb.com/docs/v5.0/tutorial/configure-ssl-clients/ SSL options are deprecated : https://www.mongodb.com/docs/v5.0/reference/configuration-options/#net.ssl-options weak_cert option is now conn_without_cert See : https://www.mongodb.com/docs/v3.0/release-notes/3.0-compatibility/#tls-ssl-configuration-option-changes
Co-authored-by: Christos Papageorgiou <[email protected]>
PR is ready ! |
Pull Request (PR) description
Add support of TLS options because SSL options are deprecated since MongoDB 4.2.
You have to switch explicitly from SSL parameters to TLS parameters in the server class.
This Pull Request (PR) fixes the following issues
Fixes #567