Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not manage the repository on RedHat when manage_package_repo is set to false #637

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

fe80
Copy link
Contributor

@fe80 fe80 commented Jan 14, 2022

Pull Request (PR) description

Hello,

For os family not equal to Debian, when you set manage_package_repo at false, that include mongodb::repo

This Pull Request (PR) fixes the following issues

Fixes #636

Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes needed. 💯 for adding a test!

manifests/globals.pp Outdated Show resolved Hide resolved
manifests/globals.pp Show resolved Hide resolved
@smortex
Copy link
Member

smortex commented Jan 14, 2022

Can you adjust the title of this PR so that when it appears in the changelog it is obvious what has changed? Something like Do not manage the repository on RedHat when manage_package_repo is set to false?

@smortex smortex self-requested a review January 14, 2022 19:39
@fe80 fe80 changed the title fix manage_package_repo #636 Do not manage the repository on RedHat when manage_package_repo is set to false #636 Jan 14, 2022
@root-expert root-expert added the bug Something isn't working label Mar 10, 2022
@root-expert root-expert changed the title Do not manage the repository on RedHat when manage_package_repo is set to false #636 Do not manage the repository on RedHat when manage_package_repo is set to false Mar 10, 2022
@root-expert root-expert merged commit 1212189 into voxpupuli:master Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mongodb::repo is always include for some family
3 participants