-
-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mongodb-shard.conf.erb #591
Conversation
fix the bind_ip usage in mongdb-shard.conf.erb, it is defined as array in manifests but config file wants it as a string ( comma separated list of ip adresses )
Good catch. There are tests for server: puppet-mongodb/spec/classes/server_spec.rb Lines 119 to 142 in 6f48edd
However, these don't exist for mongos. Could you add these so we don't risk this in the future? |
add test case for bind with multiple ip
spec/classes/mongos_spec.rb
Outdated
@@ -12,6 +12,16 @@ | |||
'/etc/mongodb-shard.conf' | |||
end | |||
end | |||
|
|||
describe 'with specific bind_ip values' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind moving this below the context 'with defaults'
block? I think it's good to always first list tests with defaults, then variations on that.
moved after defaults
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
fix the bind_ip usage in mongdb-shard.conf.erb, it is defined as array in manifests but config file wants it as a string ( comma separated list of ip adresses )
Pull Request (PR) description
This Pull Request (PR) fixes the following issues