Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined local variable or method `n' #537

Merged
merged 1 commit into from
May 21, 2019
Merged

Conversation

FunFR
Copy link
Contributor

@FunFR FunFR commented May 7, 2019

Fix Error: Failed to apply catalog: undefined local variable or method `n' for Puppet::Type::Mongodb_replset::ProviderMongo:Class

Fix Error: Failed to apply catalog: undefined local variable or method `n' for Puppet::Type::Mongodb_replset::ProviderMongo:Class
@alexjfisher alexjfisher requested a review from ekohl May 7, 2019 14:40
@alexjfisher alexjfisher added the bug Something isn't working label May 7, 2019
Copy link
Member

@alexjfisher alexjfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but before merging, I'd like to give @ekohl a chance to take a quick look. Maybe retry_count should be renamed retries_remaining or something??

@bastelfreak bastelfreak added the needs-feedback Further information is requested label May 11, 2019
@ekohl
Copy link
Member

ekohl commented May 21, 2019

If you were to implement this properly, we could use Puppet::Util::RetryAction.retry_action as well but for now I'm happy with this simple bugfix.

@ekohl ekohl merged commit 939c175 into voxpupuli:master May 21, 2019
@ekohl ekohl removed the needs-feedback Further information is requested label May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants