Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major cleanup to get the acceptance tests working #491

Merged
merged 2 commits into from
Oct 20, 2018
Merged

Major cleanup to get the acceptance tests working #491

merged 2 commits into from
Oct 20, 2018

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Oct 6, 2018 •
edited
Loading

Fixes #401

@ekohl ekohl force-pushed the fix-acceptance-tests branch 2 times, most recently from 0afc2d0 to 2c5b0ba Compare October 6, 2018 21:32
@ekohl ekohl mentioned this pull request Oct 7, 2018
Closed
@ekohl ekohl force-pushed the fix-acceptance-tests branch 4 times, most recently from fc5edee to d40674f Compare October 14, 2018 15:08
@ekohl
Copy link
Member Author

ekohl commented Oct 14, 2018

#494 is the next to be merged.

@ekohl
Copy link
Member Author

ekohl commented Oct 14, 2018

#504 is next

@ekohl ekohl mentioned this pull request Oct 14, 2018
Closed
8 tasks
@ekohl ekohl force-pushed the fix-acceptance-tests branch 4 times, most recently from d32a080 to f29cfac Compare October 20, 2018 17:13
@ekohl
Copy link
Member Author

ekohl commented Oct 20, 2018

Includes #507 & #509

@ekohl ekohl changed the title [WIP] Major cleanup to get the acceptance tests working Major cleanup to get the acceptance tests working Oct 20, 2018
@ekohl
Copy link
Member Author

ekohl commented Oct 20, 2018

Updated to remove Debian-based distros since they include a 3.x version of mongodb. The tests simply do not work on them because of an auth issue.

@ekohl
Copy link
Member Author

ekohl commented Oct 20, 2018

I did consider leaving the shared_examples style in if we want to add testing with external repos again but perhaps it's better to revisit that when we get there.

@ekohl ekohl merged commit 1e48c12 into voxpupuli:master Oct 20, 2018
@ekohl ekohl deleted the fix-acceptance-tests branch October 20, 2018 19:46
@wyardley
Copy link
Contributor

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexjfisher alexjfisher alexjfisher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ekohl @wyardley @alexjfisher