Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove trailing whitespace #86

Merged
merged 1 commit into from
Jul 6, 2016
Merged

Conversation

bastelfreak
Copy link
Member

@bastelfreak bastelfreak commented Jul 5, 2016

Please check the following items before submitting a PR -- thank you!

Note that this project is released with a Contributor Code of Conduct.
By participating in this project you agree to abide by its terms.
Contributor Code of Conduct.

  • There is no existing PR that addresses this problem
  • Mentioned any existing issues in your commit so they get linked and
    closed once this PR gets merged, i.e: Closes #1554 in the body of a commit
  • Followed the instructions in the Contributing document
  • Ran the unit/spec tests and ensured they still pass
  • Added tests to cover the new behaviour
  • Updated the documentation to match the changes
  • When possible, add an entry to the CHANGELOG file
  • Squashed your PR down to a single commit. You may forego this if the PR
    tries to address multiple issues. Though we prefer one PR per feature/fix,
    sometimes that's not feasible. In that case ensure that a single feature/fix
    and associated tests and documentation is bundled up in one commit

Optional, but extra points:

  • Added tests to ensure the old behaviour cannot accidentally be
    reintroduced

@bastelfreak bastelfreak changed the title [PCCI test - do not merge]remove trailing whitespace remove trailing whitespace Jul 6, 2016
@juniorsysadmin juniorsysadmin merged commit 65d4ac1 into voxpupuli:master Jul 6, 2016
@bastelfreak bastelfreak deleted the testpcci branch July 6, 2016 11:46
elmendalerenda pushed a commit to elmendalerenda/puppet-kafka that referenced this pull request Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants