Make wget installation optional #15
Conversation
|
To clarify my use case here, we have wget set to |
|
Are you sure this is what you wanted to push up? We've added a parameter that, as far as I can tell, doesn't do any thing. Unless ensure_resource knows how to look up the install_wget variable, which would be vomit inducing. |
danieldreier
force-pushed
the
optional_wget_install
branch
from
5710238 to
c4e3ae2
Compare
ensure_resource only matches resources as duplicate if all parameters are identical to the previously declared version. Using an explicit if not present avoids resource conflicts in the situation where wget was previously declared with ensure => latest.
danieldreier
force-pushed
the
optional_wget_install
branch
from
c4e3ae2 to
b4d6b98
Compare
|
@nibalizer you're right, I forgot to include the relevant conditional. I actually changed the approach and switched out the parameter to just check for resource conflicts using |
Make wget installation optional
|
what does puppet-kafka (or kafka?) use wget for? |
Make wget installation optional
Add an install_wget parameter to allow users to entirely disable management of wget. The require on an exec will still expect the resource to be exist, so it must be provided via another module if install_wget is set to false.