attempt to fix #3 (allow to configure service manually) #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feniix
changed the title
|
Hello: What's the status of this PR? |
|
@feniix hi, are you still interested in this PR? could you rebase it? |
|
@bastelfreak I just rebased and pushed again |
|
I am looking into the failing tests |
|
@bastelfreak Not so fast. A lot of these files will change with PR #46. |
|
@feniix sorry to ping you again :( |
feniix
force-pushed
the
master
branch
2 times, most recently
from
a1975b6 to
b50f939
Compare
|
Here we go again I also added a test for the use case |
jyaworski
added a commit
that referenced
this pull request
Mar 11, 2016
attempt to fix #3 (allow to configure service manually)
elmendalerenda
pushed a commit
to elmendalerenda/puppet-kafka
that referenced
this pull request
Mar 30, 2018
attempt to fix voxpupuli#3 (allow to configure service manually)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we would like to add the ability to completely skip the service creation/install and be able to set the state to stopped or running.