changed kafka::consumer::config from a defined type to a class

voxpupuli · Jul 25, 2017 · 6b509b4 · 6b509b4
1 parent d1d333e
commit 6b509b4
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 45 deletions.
diff --git a/README.md b/README.md
@@ -287,25 +287,17 @@ The directory to install kafka.
 
 Defined type that creates Kafka broker topics.
 
-#### Define: `kafka::consumer::config`
-
-Defined type that configures kafka consumers.
-
 ## Reference
 
 ### Classes
 
 #### Public Classes
 
 * `kafka`: Guides the basic installation of kafka binaries
-* `kafka::broker`: Guides the basic installation of a
-  kafka broker
-* `kafka::consumer`: Guides the basic installation of a
-  kafka consumer
-* `kafka::mirror`: Guides the basic installation of a
-  kafka mirror
-* `kafka::producer`: Guides the basic installation of a
-  kafka producer
+* `kafka::broker`: Guides the basic installation of a kafka broker
+* `kafka::consumer`: Guides the basic installation of a kafka consumer
+* `kafka::mirror`: Guides the basic installation of a kafka mirror
+* `kafka::producer`: Guides the basic installation of a kafka producer
 
 #### Private Classes
 
@@ -325,7 +317,6 @@ Defined type that configures kafka consumers.
 #### Defined Types
 
 * `kafka::broker::topic` Create kafka broker topics
-* `kafka::consumer::config` Create kafka broker topics
 
 ## Limitations
 

diff --git a/manifests/consumer/config.pp b/manifests/consumer/config.pp
@@ -7,7 +7,7 @@
 # This private class is meant to be called from `kafka::consumer`.
 # It manages the consumer config files
 #
-define kafka::consumer::config(
+class kafka::consumer::config(
   $config          = $kafka::consumer::config,
   $config_defaults = $kafka::consumer::config_defaults,
   $service_name    = 'kafka-consumer',
@@ -22,7 +22,7 @@
     default => undef
   }
 
-  file { "${config_dir}/${name}.properties":
+  file { "${config_dir}/consumer.properties":
     ensure  => present,
     owner   => 'root',
     group   => 'root',

diff --git a/manifests/mirror/config.pp b/manifests/mirror/config.pp
@@ -37,7 +37,7 @@
     }
   }
 
-  ::kafka::consumer::config { 'consumer-1':
+  class { '::kafka::consumer::config':
     config          => $consumer_config,
     config_defaults => $consumer_config_defaults,
     service_name    => 'kafka-mirror',

diff --git a/spec/defines/consumer_config_spec.rb b/spec/defines/consumer_config_spec.rb