Implement hyperglass-agent support #5
Conversation
bastelfreak
force-pushed
the
agent
branch
17 times, most recently
from
8417aec to
d7b4fb1
Compare
| class hyperglass::server::install { | ||
| assert_private() | ||
| user { 'hyperglass': | ||
| ensure => 'present', | ||
| managehome => true, | ||
| purge_ssh_keys => true, | ||
| system => true, | ||
| home => '/opt/hyperglass', | ||
| home => '/opt/hyperglass/hyperglass-server', |
There was a problem hiding this comment.
Perhaps you need a variable for this so you don't repeat this all the time?
|
|
||
| # Run it twice and test for idempotency | ||
| apply_manifest(pp, catch_failures: true) | ||
| apply_manifest(pp, catch_failures: true) # redis dependency needs two runs to start properly on selinux nodes |
There was a problem hiding this comment.
A workaround for that is to install the Redis package in the acceptance helper: https://github.com/theforeman/puppet-pulpcore/blob/3de6b648818410929fb9e1be7645f39063f9c61a/spec/setup_acceptance_node.pp#L13-L16 does that. You can refer to https://tickets.puppetlabs.com/browse/PUP-10548 as well.
There was a problem hiding this comment.
I'm not sure if this is a sane approach. The module can install redis. I think to not influence the resource ordering it should come from the module. It added an if clause that checks if selinux is enabled and only does the second apply_manifest() in those environments. What do you think about that?
bastelfreak
force-pushed
the
agent
branch
3 times, most recently
from
49d269d to
b9164e4
Compare
bastelfreak
force-pushed
the
agent
branch
2 times, most recently
from
7c30ce2 to
c169720
Compare
Pull Request (PR) description
This Pull Request (PR) fixes the following issues