Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update based on voxpupuli/modulesync 0.16.3 #1

Merged
merged 10 commits into from
Dec 7, 2016
Merged

Update based on voxpupuli/modulesync 0.16.3 #1

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e881718
Update based on voxpupuli/modulesync_config 0.16.3
dhoppe Dec 7, 2016
2a5da8d
Fix several Lint issues
dhoppe Dec 7, 2016
5a12d93
Fix several Rubocop issues
dhoppe Dec 7, 2016
c468612
Fix open ended dependency for puppet/archive
dhoppe Dec 7, 2016
e4e1557
Rename directory tests to examples
dhoppe Dec 7, 2016
3c9cefc
Fix several Markdown issues
dhoppe Dec 7, 2016
ee19596
Fix namespace
dhoppe Dec 7, 2016
0ccaac8
Add support for rspec-puppet-facts
dhoppe Dec 7, 2016
1f3d0ef
Fix issue regarding non numeric versions
dhoppe Dec 7, 2016
27f9cb8
Add support for anchor pattern
dhoppe Dec 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions manifests/init.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,12 +92,9 @@
fail('cfg parameter must be a hash')
}

anchor { 'grafana::begin': } ->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhoppe Great work on the modulesync PR. All looks good. This did stand out a bit though.

I thought perhaps we preferred contain over anchor?

ie like this

contain '::grafana::install'
contain '::grafana::config'
contain '::grafana::service'

Class['::grafana::install'] ->
Class['::grafana::config'] ~>
Class['::grafana::service']

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but there is an issue regarding broken dependencies. According to metadata.json Puppet >= 3.2 is supported, but contains was added at Puppet 3.4. The issuer could not use this module anymore, because he still uses Puppet 3.2.

I think this will be fixed with a lot of other stuff during the migration to Puppet 4.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, ok, if you're doing a reporter of a bug a favour, then I don't have any big problem with it.

class { '::grafana::install': } ->
class { '::grafana::config': } ~>
class { '::grafana::service': }

contain '::grafana::install'
contain '::grafana::service'

#Class['grafana']
class { '::grafana::service': } ->
anchor { 'grafana::end': }
}