Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial support for CentOS 9 #134

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Conversation

kajinamit
Copy link
Contributor

Pull Request (PR) description

This is an attempt to introduce initial support for CentOS 9, and fixes
the missing gpg key file for CentOS 9.

This Pull Request (PR) fixes the following issues

n/a

@ekohl
Copy link
Member

ekohl commented Feb 6, 2022

Right now I'm wondering why it isn't kicking off CI for CentOS 9 Stream. It should be.

@ekohl
Copy link
Member

ekohl commented Feb 6, 2022

I just opened #135 to remove EL6. It gives some impression of what should be done to add EL9.

@kajinamit
Copy link
Contributor Author

I think we need voxpupuli/puppet_metadata#36 to enable CentOS9 job.

@kajinamit
Copy link
Contributor Author

I just opened #135 to remove EL6. It gives some impression of what should be done to add EL9.

Thanks. That is very helpful, indeed. I updated my change following what are changed in that commit.

@ekohl
Copy link
Member

ekohl commented Feb 6, 2022

I'd like to merge & release voxpupuli/puppet_metadata#36 first so we get CI.

@kajinamit
Copy link
Contributor Author

Just triggering CI since now we expect CentOS9 job is enabled.

@ekohl
Copy link
Member

ekohl commented Feb 7, 2022

Looks like they indeed run, but fail. I suspect this bit needs to be modified for the tests to pass:

command = if fact('os.release.major') == '8'
'/usr/bin/yum-config-manager --dump epel'
else
'/usr/bin/yum-config-manager epel'
end

Edit: and there's more there that uses incorrect conditionals where it should treat EL8 as the default.

@kajinamit kajinamit force-pushed the centos-9 branch 2 times, most recently from 42e1252 to 130d783 Compare February 7, 2022 11:15
This is an attempt to introduce initial support for CentOS 9, and fixes
the missing gpg key file for CentOS 9.
@kajinamit
Copy link
Contributor Author

Looks like they indeed run, but fail. I suspect this bit needs to be modified for the tests to pass:

command = if fact('os.release.major') == '8'
'/usr/bin/yum-config-manager --dump epel'
else
'/usr/bin/yum-config-manager epel'
end

Edit: and there's more there that uses incorrect conditionals where it should treat EL8 as the default.

I fixed these conditions to use the same command for both CentOS 8 and CentOS 9, which hopefully helps us to add support for future CentOS 10 .
Ideally we should replace yum by dnf but I think that can be done as a separate work.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ekohl ekohl merged commit 5911d47 into voxpupuli:master Feb 7, 2022
@ekohl ekohl added the enhancement New feature or request label Feb 7, 2022
@kajinamit kajinamit deleted the centos-9 branch July 20, 2022 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants