-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial support for CentOS 9 #134
Conversation
Right now I'm wondering why it isn't kicking off CI for CentOS 9 Stream. It should be. |
I just opened #135 to remove EL6. It gives some impression of what should be done to add EL9. |
I think we need voxpupuli/puppet_metadata#36 to enable CentOS9 job. |
Thanks. That is very helpful, indeed. I updated my change following what are changed in that commit. |
I'd like to merge & release voxpupuli/puppet_metadata#36 first so we get CI. |
Just triggering CI since now we expect CentOS9 job is enabled. |
Looks like they indeed run, but fail. I suspect this bit needs to be modified for the tests to pass: puppet-epel/spec/acceptance/usage_spec.rb Lines 55 to 59 in 93c7500
Edit: and there's more there that uses incorrect conditionals where it should treat EL8 as the default. |
42e1252
to
130d783
Compare
This is an attempt to introduce initial support for CentOS 9, and fixes the missing gpg key file for CentOS 9.
I fixed these conditions to use the same command for both CentOS 8 and CentOS 9, which hopefully helps us to add support for future CentOS 10 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Pull Request (PR) description
This is an attempt to introduce initial support for CentOS 9, and fixes
the missing gpg key file for CentOS 9.
This Pull Request (PR) fixes the following issues
n/a