Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for a repository proxy #615

Merged
merged 1 commit into from
Apr 22, 2016
Merged

added support for a repository proxy #615

merged 1 commit into from
Apr 22, 2016

Conversation

tosmi
Copy link
Contributor

@tosmi tosmi commented Apr 15, 2016

As part of your pull request, please review the following tasks:

  • [X ] Signed the CLA (if not already signed)
  • [ X] Rebased/up-to-date with base branch
  • [ X] Tests pass

currently only for redhat yum repos

currently only for redhat yum repos
@tylerjl
Copy link
Contributor

tylerjl commented Apr 18, 2016

This looks great, @tosmi. Thank you for the tests as well 👍

You mentioned you signed the CLA, though the check doesn't seem to be passing - not sure whether that's on our side or not, I'm looking into it. Note that the CLA check will verify against the author information in the git commit.

@tosmi
Copy link
Contributor Author

tosmi commented Apr 18, 2016

hm, ok the cla ask for my gitlab username, which is tosmi. the email address i'm using in my commit's is toni at stderr dot at. maybe that's a problem... drop me a note if i can do anything.

@tylerjl tylerjl merged commit 1f720d8 into voxpupuli:master Apr 22, 2016
@tylerjl tylerjl added this to the 0.10.4 milestone May 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants