Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CvmFS 2.11.0 parameters #186

Merged
merged 7 commits into from
Sep 5, 2023
Merged

Conversation

traylenator
Copy link
Contributor

@traylenator traylenator commented Sep 5, 2023

Pull Request (PR) description

With the release of CvmFS 2.11.0 there are 8 new client
parameters that can be set:

For instance:

class{'cvmfs':
  cvmfs_cache_symlinks => 'yes',
  cvmfs_streaming_cache => 'no',
  cvmfs_statfs_cache_timeout => 10,
  cvmfs_world_readable => 'yes',
  cvmfs_cpu_affinity => [0,1,2],
  cvmfs_xattr_privileged_gids => [100,101,102],
  cvmfs_xattr_protected_xattrs => ['user.foo','user.bar'],
  cvmfs_cache_refcount => 'yes',
}

Couple of extra commits fix some typos and lint correction on parameter order.

With the release of CvmFS 2.11.0 there are 7 new client
parameters that can be set:

For instance:

```
class{'cvmfs':
  cvmfs_cache_symlinks => 'yes',
  cvmfs_streaming_cache => 'no',
  cvmfs_statfs_cache_timeout => 10,
  cvmfs_world_readable => 'yes',
  cvmfs_cpu_affinity => [0,1,2],
  cvmfs_xattr_privileged_gids => [100,101,102],
  cvmfs_xattr_protected_xattrs => ['user.foo','user.bar'],
}
```

* CvmFS 2.11.0 release notes https://cvmfs.readthedocs.io/en/stable/cpt-releasenotes.html
* CvmFS parameters https://cvmfs.readthedocs.io/en/stable/apx-parameters.html
@jblomer
Copy link
Contributor

jblomer commented Sep 5, 2023

This is missing the CVMFS_CACHE_REFCOUNT parameter, isn't it?

Copy link
Contributor

@olifre olifre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me in general, just a few nits in the individual comments. Anf of course I second @jblomer 's question, it would be nice to add CVMFS_CACHE_REFCOUNT while at it 👍 .

spec/classes/init_spec.rb Outdated Show resolved Hide resolved
spec/classes/init_spec.rb Outdated Show resolved Hide resolved
spec/classes/init_spec.rb Outdated Show resolved Hide resolved
@traylenator traylenator closed this Sep 5, 2023
@traylenator
Copy link
Contributor Author

CVMFS_CACHE_REFCOUNT added. ( closed by accident)

@traylenator traylenator reopened this Sep 5, 2023
Copy link
Contributor

@olifre olifre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks good to me 👍 .

@traylenator traylenator merged commit d65f3fb into voxpupuli:master Sep 5, 2023
29 of 56 checks passed
@traylenator traylenator deleted the refcount branch September 5, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants