Remove unnecessary test on $service_ensure #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$service_ensure is required by init.pp to have type Stdlib::Ensure::Service, so there is no need for this test.
igalic
reviewed
Jul 12, 2020
| @@ -7,10 +7,6 @@ | |||
| $service_manage = $chrony::service_manage, | |||
| $service_name = $chrony::service_name, | |||
| ) inherits chrony { | |||
There was a problem hiding this comment.
why does this class inherit from chrony
that's really bad form for anything other than the params class
There was a problem hiding this comment.
I have no idea. It has been that way since commit 74c0dc8 when the the file was added.
There was a problem hiding this comment.
okay
let's remove those in a future PR
i'm pretty, and sure, there's a standard puppet lint that should be complaining about this
have we gotten module/pdk sync yet for this module?
ekohl
approved these changes
Jul 13, 2020
|
Oops. I will have to change the tests also. Don't merge until I have fixed that. |
The name defaults to the resource title, and both hasstatus ans hasrestart is default true.
igalic
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$service_ensure is required by init.pp to have type Stdlib::Ensure::Service, so there is
no need for this test.