Add tests for gentoo #86
Conversation
spec/classes/chrony_spec.rb
Outdated
| ['0.pool.ntp.org', '1.pool.ntp.org', '2.pool.ntp.org', '3.pool.ntp.org'].each do |s| | ||
| it { is_expected.to contain_file('/etc/chrony/chrony.conf').with_content(%r{^\s*server #{s} iburst$}) } | ||
| end |
There was a problem hiding this comment.
I'd prefer to avoid multiple it statements:
| ['0.pool.ntp.org', '1.pool.ntp.org', '2.pool.ntp.org', '3.pool.ntp.org'].each do |s| | |
| it { is_expected.to contain_file('/etc/chrony/chrony.conf').with_content(%r{^\s*server #{s} iburst$}) } | |
| end | |
| it do | |
| is_expected.to contain_file('/etc/chrony/chrony.conf') | |
| .with_content(%r{^\s*server 0.pool.ntp.org iburst$}) | |
| .with_content(%r{^\s*server 1.pool.ntp.org iburst$}) | |
| .with_content(%r{^\s*server 3.pool.ntp.org iburst$}) | |
| end |
There was a problem hiding this comment.
Yes, I agree. But then that should be fixed for the other osfamily also. If you like, I can add a commit for that in this PR?
spec/classes/chrony_spec.rb
Outdated
| it { is_expected.to contain_file('/etc/chrony/chrony.keys').with_mode('0644') } | ||
| it { is_expected.to contain_file('/etc/chrony/chrony.keys').with_owner('0') } | ||
| it { is_expected.to contain_file('/etc/chrony/chrony.keys').with_group('0') } | ||
| it { is_expected.to contain_file('/etc/chrony/chrony.keys').with_replace(true) } | ||
| it { is_expected.to contain_file('/etc/chrony/chrony.keys').with_content("0 xyzzy\n") } |
There was a problem hiding this comment.
Same here. Multiple it statements require the catalog to be compiled multiple times and is much slower in my experience.
There was a problem hiding this comment.
Same reply here, it should be fixed for all osfamily.
There was a problem hiding this comment.
my suggestion:
fix for Gentoo as suggested by @ekohl, fix for other OSes in new pr
add a TODO comment, if you're the forgetful type ;)
|
I have updated the PR with the suggested changes. I agree, this looks so much better. I'll submit a PR for the other osfamily later. |
|
And thank you for all good reviews, not only are we improving the code, but I'm learning a lot and having fun doing it. |
No description provided.