Fix wrong end-tag resulting in blank line.

[chrekh]

No description provided.

[igalic]

🙋🏻‍♀️
how is this module currently tested?

how could we regression test changes between module upgrades anyway??

[chrekh]

how could we regression test changes between module upgrades anyway??

Perhaps we could add .without_content(%r{^\s*\n\s*$}) to test for double blank lines?

[chrekh]

Perhaps we could add .without_content(%r{^\s*\n\s*$}) to test for double blank lines?

I tried that, and imediately found an other bug

<% if $chrony::refclocks { -%>

<%   $chrony::refclocks.each |$driver| { -%>
refclock <%= $driver.flatten.join(' ') %>
<%   } -%>
<% } -%>

Is adding a blank line when refclocks is []

[igalic]

you want to test whether that is empty then, or else give it undef as default

[chrekh]

you want to test whether that is empty then, or else give it undef as default

I think we should add type constrain Array to it in init.pp instead. And just remove the if test.

[igalic]

the if controls the insertion of a newline refclock, so the test should be for empty()

[chrekh]

the if controls the insertion of a newline refclock, so the test should be for empty()

And ofcourse you are right. The if is still needed even if we require refclock to be Array. I'll prepare a PR for that.

[igalic]

since this pr is about fixing whitespace, i'd do that here.

[chrekh]

Make sense, ok, I'll do that.

[igalic]

please also add that test you spoke about, i don't see it
then, this should be good to go

[chrekh]

Ok, I'll rebase to master (because the added gentoo tests) and add a test for double blank lines. I'll add a separate PR later for restructuring the tests to match the gentoo case.