Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert template for chrony.keys from erb to epp #83

Merged
merged 1 commit into from
Jul 11, 2020

Conversation

chrekh
Copy link
Contributor

@chrekh chrekh commented Jul 11, 2020

No description provided.

Copy link
Contributor

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question, but looks good otherwise

<% if $chrony::chrony_password and $chrony::chrony_password != 'unset' { -%>
<%= $chrony::commandkey %> <%= $chrony::chrony_password %>
<% } -%>
<% $chrony::keys.each |$line| { -%>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are keys guaranteed to be at least []?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. Yes, the required type defined in init.pp for $keys is Array[String[1]]

@alexjfisher
Copy link
Member

@chrekh Thanks!

@alexjfisher alexjfisher merged commit 1cef345 into voxpupuli:master Jul 11, 2020
@chrekh chrekh deleted the epp2 branch July 12, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants