Add new driftfile, hwtimestamps, rtcsync, and dumpdir parameters
#82
Conversation
|
Rebased to master/HEAD because the need to add defaultvalue for $dumpdir for Gentoo in params.pp |
REFERENCE.md
Outdated
|
|
||
| Data type: Boolean | ||
|
|
||
| Periodically sync syste time to RTC |
There was a problem hiding this comment.
Yes, good catch. Do you prefer that I add a small typo-fix commit, or a rebase -i and a force-push?
REFERENCE.md
Outdated
| Data type: `Variant[Hash,Array[String]]` | ||
|
|
||
| This selects interfaces to enable hardware timestamps on. It can be an array of interfaces | ||
| or a hash of interfaces to ther respective options. |
There was a problem hiding this comment.
typo here too. The code looks correct though. I guess REFERENCE.MD just needs regenerating?
| @@ -120,3 +128,12 @@ smoothtime <%= $chrony::smoothtime %> | |||
| # https://chrony.tuxfamily.org/doc/3.4/chrony.conf.html#rtconutc | |||
| rtconutc | |||
| <% } -%> | |||
| <% if ! $chrony::hwtimestamps.empty { -%> | |||
There was a problem hiding this comment.
Would unless be more readable than if !?
There was a problem hiding this comment.
Interesting that you should mention that. I myself prefer unless before if ! in any language that supports it. But, I know people that hates unless. :)
There was a problem hiding this comment.
There are more 'if !' in the template, I can add a separate PR later that changes them all to unless, and se if someone else objects.
|
Would you be able to add any extra tests to cover the new options? In particular, it'd be good to test that |
alexjfisher
changed the title
driftfile, hwtimestamps, rtcsync, and dumpdir parameters
Yes, I can do that. |
To avoid having it hardcoded by the template.
To avoid having it hardcoded by the template.
To be able to specify directory for chrony to save measurement in on exit. When dumpdir is set, both option dumponexit and dumpdir is added to chrony.conf dumponexit and dumpdir was before b971db0 hardcoded in the template for archlinux. This commit is restoring the default value for Archlinux, and leaving the default unset on other os.
|
I have rebased to master, fixed the typos, and added tests in the commits for each param |
The params added with this PR are:
driftfile, hwtimestamps, rtcsync, and dumpdir. Each with it's separate commit.