Remove default value of 0 for $port and allow $port to be unset #81
Conversation
| if $queryhosts != [] and $port == 0 { | ||
| fail("Setting \$queryhosts has no effect unless also setting \$port which defaults to 0 in ${module_name}, refusing that.") | ||
| } |
There was a problem hiding this comment.
Should this be kept in but with and !$port?
There was a problem hiding this comment.
I don't think so. The point of this change is that I want to accept client access without needing to specify the port, which then is the default ntp-port 123. But as you said, this needs to be reviewed by someone more with chrony knowledge.
I also noticed that the unit-test failed. I need to also change the test. Unit-testing is a great thing! :)
|
It'd be nice if anyone with chrony knowledge could review this instead of me. |
Also remove the requirement for $port to be set if $qeryhost is used. If there is no
'allow' in chrony.conf the server doesn't allow client access, no need to also set port to
0. And if there is 'allow' in chrony.conf the default port to listen on is the expected
123.
From chrony.conf(5)
port port
This option allows the UDP port on which the server understands NTP requests to be
specified. For normal servers this option should not be required (the default is 123,
the standard NTP port).
|
I think this is ok. The template's use of |
indeed. 0 in ruby is "truthy": 0 as a port in TCP/UCP |
Also remove the requirement for $port to be set if $qeryhost is used. If there is no
'allow' in chrony.conf the server doesn't allow client access, no need to also set port to
0. And if there is 'allow' in chrony.conf the default port to listen on is the expected
123.
From chrony.conf(5)
port port
This option allows the UDP port on which the server understands NTP requests to be
specified. For normal servers this option should not be required (the default is 123,
the standard NTP port).