Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add leapsectz option config option #65

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Conversation

adrienthebo
Copy link
Member

This pull request exposes the leapsectz option, which when set uses a specified offset from UTC to set CLOCK_TAI.

This current revision has tests but could probably benefit from additional work. In addition it looks like the leapsecmode option isn't plumbed through on archlinux and I haven't pushed leapsectz through either. I'm happy to fix that in another PR or incorporate those fixes here.

@aboe76
Copy link
Contributor

aboe76 commented Jan 30, 2020

@adrienthebo nice work, thanks for this, I don't mind future PR's from you!!!
Please do fix Archlinux 'leapsectz' and 'leapsecmode'

@aboe76 aboe76 merged commit 8604e8e into voxpupuli:master Jan 30, 2020
@adrienthebo
Copy link
Member Author

Thank you!

@adrienthebo adrienthebo deleted the leapsectz branch January 31, 2020 12:44
@aboe76
Copy link
Contributor

aboe76 commented Jan 31, 2020

@adrienthebo is this module something vox pupuli would want to take over?

@alexjfisher
Copy link
Member

Looks like I've just described #64

@alexjfisher
Copy link
Member

@adrienthebo is this module something vox pupuli would want to take over?

Woah! Completely missed this comment. Yes, if you're open to that, I'm sure people would be interested. I can personally help with the migration too.

@alexjfisher
Copy link
Member

https://voxpupuli.org/docs/migrate_module
@aboe76 If you have any questions, the best place is either freenode irc #voxpupuli or the voxpupuli channel on slack https://slack.puppet.com

I'll preemptively send you a github invite, but also no worries if you've changed your mind and would prefer not to migrate your module.

@aboe76
Copy link
Contributor

aboe76 commented Feb 14, 2020

@alexjfisher no problem, I have joined by your invite.
time to read up

@alexjfisher
Copy link
Member

@aboe76 Have you had any more thoughts on this and are you ready to perform the migration?

@aboe76
Copy link
Contributor

aboe76 commented Feb 22, 2020

@alexjfisher yes I have, I would like to migrate the chrony module. I would like to ask you to assist with this. The reason for the migration is to improve the support and maintenance.

@alexjfisher
Copy link
Member

Great! I've got some time free to do most of the migration process. All you really need to do is transfer the repository to the voxpupuli github organisation. Once we've made the first puppet/chrony release, you can use the puppet forge api to deprecate aboe76/chrony and suggest puppet/chrony as its replacement.

@alexjfisher
Copy link
Member

I've created an issue with a checklist of stuff to do. Vox Pupuli can handle everything apart from the first and last steps.

@alexjfisher alexjfisher added the enhancement New feature or request label Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants