Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance parameter validation with more data types #63

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

alexjfisher
Copy link
Member

Also added puppet strings docs for the parameters which previously had
none.

Also added puppet strings docs for the parameters which previously had
none.
@aboe76 aboe76 merged commit 76db1bb into voxpupuli:master Jan 21, 2020
@aboe76
Copy link
Contributor

aboe76 commented Jan 21, 2020

@alexjfisher thanks for your hard work, it starting to look like a better module thanks to you.
I shall cut a new release this weekend, if you have an idea on how to automate this process, it will be appreciated !!!. :)

@alexjfisher
Copy link
Member Author

@alexjfisher thanks for your hard work, it starting to look like a better module thanks to you.
I shall cut a new release this weekend, if you have an idea on how to automate this process, it will be appreciated !!!. :)

At Vox Pupuli, we have travis deploy to the forge.
It's setup to build tags that are releases.
The build rake task packages the module.(We use puppet 5 for this as puppet 6 requires pdk which we don't use).
Forge credentials are encrypted.

@aboe76
Copy link
Contributor

aboe76 commented Feb 14, 2020

@alexjfisher that would be handy, no more building the module by hand and uploading it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants