Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move static defaults out of params.pp #61

Merged
merged 1 commit into from
Jan 19, 2020

Conversation

alexjfisher
Copy link
Member

By moving the non OS specific defaults back into init.pp, puppet-strings
can now use them in REFERENCE.md

By moving the non OS specific defaults back into init.pp, puppet-strings
can now use them in REFERENCE.md
@aboe76
Copy link
Contributor

aboe76 commented Jan 17, 2020

@alexjfisher why does the acceptance test fail? any idea?
maybe we test against the wrong puppet version?

@alexjfisher
Copy link
Member Author

Did you mean to switch back to beaker from litmus in fd84538#diff-354f30a63fb0907d4ad57269548329e3L31-L38 ?

@alexjfisher
Copy link
Member Author

I'm not really a big pdk user, but it looks like you'd need to modify .sync.yml and rerun pdk update. This is the first example I found. https://github.com/puppetlabs/puppetlabs-motd/blob/master/.sync.yml

@alexjfisher
Copy link
Member Author

I'm almost out of time for today, but puppetlabs/pdk-templates#296 looks interesting

@alexjfisher
Copy link
Member Author

Ta-dah! #62

Might need tweaking later, but this gets things going again.

@aboe76 aboe76 merged commit acc78a0 into voxpupuli:master Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants