Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove empty dirs and gitkeeps #49

Merged
merged 1 commit into from
Aug 14, 2019
Merged

remove empty dirs and gitkeeps #49

merged 1 commit into from
Aug 14, 2019

Conversation

iglov
Copy link

@iglov iglov commented Aug 14, 2019

Why u do this? In each node puppet creates
Notice: /File[/opt/puppetlabs/puppet/cache/lib/puppet/provider/.gitkeep]/ensure: defined content as '{md5}d41d8cd98f00b204e9800998ecf8427e' Notice: /File[/opt/puppetlabs/puppet/cache/lib/puppet/type/.gitkeep]/ensure: defined content as '{md5}d41d8cd98f00b204e9800998ecf8427e'

@iglov
Copy link
Author

iglov commented Aug 14, 2019

LOL and why in the directory of module when it installed with puppet module install aboe-chrony --version 0.3.0 there are many dirs and files which should not be there 8D

$ ls -lah modules/chrony/
total 92K
drwxr-xr-x  7 root root 4.0K Aug  5 21:27 .
drwxrwxr-x 23 root root 4.0K Aug 14 14:56 ..
-rw-rw-r--  1 root root 5.6K Aug  5 21:19 CHANGELOG.md
-rw-rw-r--  1 root root 3.2K Apr 25 21:14 CONTRIBUTING.md
-rw-rw-r--  1 root root   14 Apr 25 21:14 CONTRIBUTORS
-rw-rw-r--  1 root root  475 Apr 25 21:14 Dockerfile
-rw-rw-r--  1 root root  206 Apr 25 21:14 .editorconfig
drwxr-xr-x  2 root root 4.0K Aug  5 21:27 examples
drwxr-xr-x  3 root root 4.0K Aug  5 21:27 lib
-rw-rw-r--  1 root root  582 Apr 25 21:14 LICENSE
drwxr-xr-x  2 root root 4.0K Aug  5 21:27 manifests
-rw-rw-r--  1 root root 1.1K Aug  5 21:20 metadata.json
-rw-rw-r--  1 root root   35 Apr 25 21:14 .msync.yml
-rw-rw-r--  1 root root 1.4K Apr 25 21:14 .overcommit.yml
-rw-rw-r--  1 root root  234 Apr 25 21:14 .pmtignore
-rw-rw-r--  1 root root   11 Aug  2 20:17 .puppet-lint.rc
-rw-rw-r--  1 root root 7.3K Aug  5 21:16 README.md
-rw-rw-r--  1 root root   18 Apr 25 21:14 .rspec_parallel
-rw-rw-r--  1 root root  366 Apr 25 21:14 .sync.yml
drwxr-xr-x  2 root root 4.0K Aug  5 21:27 templates
drwxr-xr-x  2 root root 4.0K Aug  5 21:27 .travis

wtf bruw? Plz look how it is done for ex. in puppet-nginx ...
Could u plz remove it all from puppet forge release?

@aboe76
Copy link
Contributor

aboe76 commented Aug 14, 2019

@iglov I have mimicked the puppetlabs-motd repo: https://github.com/puppetlabs/puppetlabs-motd
and some ideas from voxpupuli to test and give some options.

But I can remove the empty directories, you are correct those aren't needed.

@aboe76 aboe76 merged commit 07d1b32 into voxpupuli:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants