queryhosts: enforce Array[String] data type #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test failures are unrelated to this change. |
|
I've reopened #93 but need to resolve conflicts. |
The conversion from ERB to EPP in voxpupuli#79 changed the behavior of queryhosts slightly. Before, setting queryhosts to the empty string worked for configuring chrony to allow any query. After, empty string is considered empty, so the "allow" directive would not be rendered. Enforcing the data type ensures that people upgrading this module who have been using empty string get an error rather than a valid but misconfigured chrony.conf. The replacement for empty string is an array with a single empty string element: ['']
This file shouldn't be in the repository. Its existence in the repository causes rake test to fail if you have this gitignored. This isn't the current name of the puppet vscode extension, and it's not necessary to have this file anyway.
kenyon
force-pushed
the
allow-empty-queryhosts
branch
from
f0fea09 to
ea71bb6
Compare
bastelfreak
approved these changes
Nov 17, 2020
kenyon
added a commit
to kenyon/puppet-chrony
that referenced
this pull request
Dec 10, 2022
Commit ee2d9de changed the data type for queryhosts from Array[String] to Array[String[1]]. These parameters configure `allow` and `deny` in chrony.conf. But `allow` and `deny` are allowed to be by themselves in the config, meaning "allow everything" or "deny everything": https://chrony.tuxfamily.org/doc/4.3/chrony.conf.html#allow This commit corrects the data type to Array[String[0]] and adds a test to prevent future breakage (this was broken before too, and I fixed it again in voxpupuli#101).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conversion from ERB to EPP in #79 changed the behavior of queryhosts slightly. Before, setting queryhosts to the empty string worked for configuring chrony to allow any query. After, empty string is considered empty, so the "allow" directive would not be rendered.
Enforcing the data type ensures that people upgrading this module who have been using empty string get an error rather than a valid but misconfigured chrony.conf. The replacement for empty string is an array with a single empty string element: ['']
Also, fixing a typo in the tests.
I also removed an obsolete vscode extensions.json (the puppet extension name is obsolete). I have the whole .vscode directory git-ignored, so
bundle exec rake testaborts when it sees that something ignored exists in the repository. I don't think we really need this file.