Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update metadata to remove puppet-stdlib dependency #42

Closed
vchepkov opened this issue Jun 18, 2019 · 3 comments
Closed

update metadata to remove puppet-stdlib dependency #42

vchepkov opened this issue Jun 18, 2019 · 3 comments

Comments

@vchepkov
Copy link
Contributor

I can submit a simple PR to update version in metadata.json, but I think the more proper fix would be to remove dependency on stdlib altogether. Unless I missed it, I don't see any stdlib functions or types that module uses.
@aboe76
Copy link
Contributor

aboe76 commented Jun 18, 2019

Please create a pr with your proper fix, I will merge it.

vchepkov pushed a commit to vchepkov/puppet-chrony that referenced this issue Jun 18, 2019
(voxpupuli#42) remove dependency on puppetlabs-stdlib
3035885
vchepkov added a commit to vchepkov/puppet-chrony that referenced this issue Jun 18, 2019
@vchepkov
(voxpupuli#42) remove dependency on puppetlabs-stdlib
d17862f
@vchepkov vchepkov changed the title update metadata to support puppet-sdlib v6 update metadata to remove puppet-stdlib dependency Jun 18, 2019
@vchepkov
Copy link
Contributor Author

PR #43 has been created

aboe76 added a commit that referenced this issue Jun 22, 2019
@aboe76
Merge pull request #43 from vchepkov/no-stdlib
3ef4863 
(#42) remove dependency on puppetlabs-stdlib
@aboe76
Copy link
Contributor

aboe76 commented Aug 2, 2019

pushed new version 0.2.6 on forge

@aboe76 aboe76 closed this as completed Aug 5, 2019
cegeka-jenkins pushed a commit to cegeka/puppet-chrony that referenced this issue Nov 27, 2019
@vchepkov
(voxpupuli#42) remove dependency on puppetlabs-stdlib
223b4b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vchepkov @aboe76