Allow trusted facts to be derived from node name #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the certless API, Puppet will use trusted facts from PuppetDB unless provided in the request. If the PuppetDB facts were uploaded by the catalog_diff host, the trusted facts in PuppetDB will be for the catalog_diff host rather than the node being evaluated. This allows the trusted facts to be derived from the node name instead of using values from PuppetDB.
nabertrand
force-pushed
the
trusted_facts
branch
from
7e3607f
to
e686db4
Compare
|
@nabertrand hi! Sorry for the late reply, I somehow missed the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow trusted facts to be derived from node name
When using the certless API, Puppet will use trusted facts from PuppetDB unless provided in the request. If the PuppetDB facts were uploaded by the catalog_diff host, the trusted facts in PuppetDB will be for the catalog_diff host rather than the node being evaluated. This allows the trusted facts to be derived from the node name instead of using values from PuppetDB.
Perhaps there is a way to have Puppet store the trusted facts as presented in the facts file being uploaded, but from what I can tell the facts API always replaces trusted facts with data derived from the client cert.