Fix failed nodes report #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Fix visibility on failed nodes in the output report for the Catalog Diff Viewer
PR 50 introduced a bug where the pull_output is not being added to the nodes hash when the report is written.
Adding pull_output back to the nodes hash to be written to the json report.
This allows the Catalog Diff Viewer to see failed nodes in the report.
Changing the compile catalog to print body instead of reason when a compile fails as it provides the log entry with reason why compile failed for the node.
This Pull Request (PR) fixes the following issues
Fixes #92