Add support for puppetlabs/strings #48
Conversation
| @@ -3,6 +3,7 @@ | |||
| docker_sets: | |||
| - set: centos6-64 | |||
| - set: centos7-64 | |||
| - set: centos8-64 | |||
There was a problem hiding this comment.
That was missing at a pull request I merged earlier today.
|
|
||
| ### Setup Requirements | ||
|
|
||
| This module has the following dependencies: |
There was a problem hiding this comment.
Do we need to list these? IMHO metadata.json is a better place.
There was a problem hiding this comment.
I have no idea. We have these dependencies at metadata.json, but it is nice to get an quick overview without jumping through all these files.
However, it is almost impossible to create a good README.md, because all of our modules use a different style and we do not have a reference module like puppetlabs/puppetlabs-apt.
| String $caddy_features = 'http.filter,http.git,http.ipfilter', | ||
| Stdlib::Port $caddy_http_port = 80, | ||
| Stdlib::Port $caddy_https_port = 443, | ||
| Stdlib::Absolutepath $install_path = '/usr/local/bin', |
There was a problem hiding this comment.
I have stopped aligning because I think it just makes things hard to maintain. Won't object, but I wouldn't bother.
There was a problem hiding this comment.
Yeah, this mess came with the data types, but I think it is easier to read this way.
manifests/service.pp
Outdated
| 'redhat': { # we could probably add 'debian' for older debian releases but not sure | ||
| file {'/etc/init.d/caddy': | ||
| 'redhat': { | ||
| file { '/etc/init.d/caddy': | ||
| ensure => file, | ||
| mode => '0744', |
There was a problem hiding this comment.
Unrelated, but what a weird mode. 0755 is much more logical IMHO.
There was a problem hiding this comment.
Yeah, this was already in here and nobody cared about it. I will change it. ;)
manifests/vhost.pp
Outdated
| # | ||
| define caddy::vhost( | ||
| $source = undef, | ||
| $content = undef, | ||
| $source = undef, |
There was a problem hiding this comment.
Undocumented, also
| $source = undef, | |
| Optional[Stdlib::Filesource] $source = undef, |
There was a problem hiding this comment.
Thx. I missed that somehow.
manifests/vhost.pp
Outdated
| $source = undef, | ||
| $content = undef, | ||
| $source = undef, | ||
| $content = undef, |
There was a problem hiding this comment.
Undocumented, also
| $content = undef, | |
| Optional[String] $content = undef, |
There was a problem hiding this comment.
Thx. I missed that somehow.
|
@ekohl Just generated a new |
|
Dear @dhoppe, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
1 similar comment
|
Dear @dhoppe, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
Seems to duplicate #49 which was merged. Please re-open if that's not the case. |
dhoppe
changed the title
Fixes #33, #44