Add support for puppet/archive #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Apr 26, 2020
metadata.json
Outdated
| "dependencies": [ | ||
| { | ||
| "name": "puppet/archive", | ||
| "version_requirement": ">= 4.0.0 < 5.0.0" |
There was a problem hiding this comment.
If I introduce a new dependency, I always add the last release as lower bound because thats the version where we know it works. That would be 4.4.0 for archive. But I don't think that there is an official recommendation in the style guide.
There was a problem hiding this comment.
I was just looking for the first Puppet 5+ only release. But 4.3.0 should be ok, because it added support for CentOS 8.
There was a problem hiding this comment.
I just saw that 4.4.0 fixed an issue related to cookies / proxies and fixed the lower boundary.
bastelfreak
approved these changes
Apr 26, 2020
bastelfreak
approved these changes
Apr 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30