Allow to install caddy from repos #114
Conversation
jay7x
force-pushed
the
manage_repo
branch
2 times, most recently
from
9a80cc2 to
9a6dcf0
Compare
| # | ||
| class caddy ( | ||
| String[1] $version = '2.0.0', | ||
| Optional[Enum['github']] $install_method = undef, | ||
| Optional[Enum['github','repo']] $install_method = undef, |
There was a problem hiding this comment.
I am wondering if we should remove the 'Optional' part and add something like 'upstream'. Some people use Hiera to change settings in modules, and the current way make it impossible to revert to upstream on one host if another level in the hierarchy set it to something else.
There was a problem hiding this comment.
Yes, I have that in my mind, but it'll be breaking change (potentially, if someone do class { 'caddy': install_method => undef }). So far I'm trying to keep backward compatibility.
There was a problem hiding this comment.
I mean, I'll change this, just in different PR.
|
#115 is required to be merged before to fix acceptance tests. |
jay7x
force-pushed
the
manage_repo
branch
2 times, most recently
from
dc75bdf to
0cd7c9b
Compare
jay7x
force-pushed
the
manage_repo
branch
2 times, most recently
from
b755324 to
4d3d8cd
Compare
|
Debian family is good now. Need to fix voxpupuli/puppet-yum#340 to make RedHat family happy. |
Closes #62